View on GitHub

RefactoringPHP

A PHP version of the refactors from Refactoring: Improving the Design of Existing Code (Second Edition) by Martin Fowler

Split Loop (227)

Old Code

<?php
$averageAge = 0;
$totalSalary = 0;
foreach($people as $p) {
    $averageAge += $p->age;
    $totalSalary += $p->salary;
}

$averageAge = $averageAge / count($people);

New Code

<?php
$totalSalary = 0;
foreach($people as $p) {
    $totalSalary += $p->salary;
}

$averageAge = 0;
foreach($people as $p) {
    $averageAge += $p->age;
}
$averageAge = $averageAge / count($people);